mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
Date Sat, 01 Nov 2014 02:28:46 GMT


> On Oct. 31, 2014, 4:42 p.m., Adam B wrote:
> > Not sure why a change from your 3rd patch fails to find a file included in the 2nd
patch, but this change looks shippable.
> > ../../src/master/master.cpp:56:44: fatal error: authentication/authenticator.hpp:
No such file or directory
> >  #include "authentication/authenticator.hpp"
> >  
> > I'll try applying all 4 patches myself and building it on two different machines.
If that succeeds, I'll try committing it and wait for Jenkins to approve.

The distcheck issue is fixed, also fixed the incorrect include of the original auxprop.hpp
which could cause compilation issues.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/#review59356
-----------------------------------------------------------


On Oct. 31, 2014, 11:18 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26860/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 11:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
> 
> 
> Bugs: MESOS-1889
>     https://issues.apache.org/jira/browse/MESOS-1889
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
> 
> Example usage:
> bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator --modules="{\"libraries\":
[{\"file\": \"src/.libs/libtestauthenticator.so\",\"modules\": [{\"name\": \"org_apache_mesos_TestCRAMMD5Authenticator\"}]}]}"
> 
> 
> Diffs
> -----
> 
>   src/tests/flags.hpp 2886e89 
>   src/tests/mesos.cpp 2e8e39a 
> 
> Diff: https://reviews.apache.org/r/26860/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> bin/mesos-tests.sh --authenticators=org_apache_mesos_TestCRAMMD5Authenticator --modules="{\"libraries\":
[{\"file\": \"src/.libs/libtestauthenticator.dylib\",\"modules\": [{\"name\": \"org_apache_mesos_TestCRAMMD5Authenticator\"}]}]}"
--verbose --gtest_filter="AuthenticationTest.AuthenticatedSlave"
> 
> Shows:
> I1024 06:16:14.764703 298631168 master.cpp:3874] Using 'org_apache_mesos_TestCRAMMD5Authenticator'
authenticator
> 
> bin/mesos-tests.sh --verbose --gtest_filter="AuthenticationTest.AuthenticatedSlave"
> 
> Shows:
> I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5 authenticator
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message