Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E2108179D3 for ; Fri, 31 Oct 2014 15:57:38 +0000 (UTC) Received: (qmail 56128 invoked by uid 500); 31 Oct 2014 15:57:38 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 56059 invoked by uid 500); 31 Oct 2014 15:57:38 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 56042 invoked by uid 99); 31 Oct 2014 15:57:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Oct 2014 15:57:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 810471DF99B; Fri, 31 Oct 2014 15:57:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1418450577641477687==" MIME-Version: 1.0 Subject: Re: Review Request 26486: Fix containerizer not receiving destroy/update calls when launching. From: "Benjamin Hindman" To: "Benjamin Hindman" Cc: "Timothy Chen" , "mesos" Date: Fri, 31 Oct 2014 15:57:42 -0000 Message-ID: <20141031155742.7138.78013@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26486/ X-Sender: "Benjamin Hindman" References: <20141021044201.1282.11809@reviews.apache.org> In-Reply-To: <20141021044201.1282.11809@reviews.apache.org> Reply-To: "Benjamin Hindman" X-ReviewRequest-Repository: mesos-git --===============1418450577641477687== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26486/#review59350 ----------------------------------------------------------- Ship it! src/slave/containerizer/composing.cpp Move update to previous line and wrap after '(' please. - Benjamin Hindman On Oct. 21, 2014, 4:42 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26486/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 4:42 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1884 and MESOS-1915 > https://issues.apache.org/jira/browse/MESOS-1884 > https://issues.apache.org/jira/browse/MESOS-1915 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/26486 > > > Diffs > ----- > > src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 > src/slave/containerizer/composing.cpp 9022700b628d9746a6a8a17c9fbf1b1988da6fca > src/tests/composing_containerizer_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/26486/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > > --===============1418450577641477687==--