Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7137017D7C for ; Tue, 28 Oct 2014 22:50:37 +0000 (UTC) Received: (qmail 909 invoked by uid 500); 28 Oct 2014 22:50:37 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 842 invoked by uid 500); 28 Oct 2014 22:50:37 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 781 invoked by uid 99); 28 Oct 2014 22:50:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 22:50:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1B8901DF807; Tue, 28 Oct 2014 22:50:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6625231631856088386==" MIME-Version: 1.0 Subject: Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests. From: "Kapil Arya" To: "Benjamin Hindman" , "Adam B" , "Vinod Kone" Cc: "mesos" , "Kapil Arya" , "Till Toenshoff" Date: Tue, 28 Oct 2014 22:50:41 -0000 Message-ID: <20141028225041.7138.2398@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26860/ X-Sender: "Kapil Arya" References: <20141025203510.1282.76214@reviews.apache.org> In-Reply-To: <20141025203510.1282.76214@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos-git --===============6625231631856088386== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26860/#review58906 ----------------------------------------------------------- Ship it! Ship It! - Kapil Arya On Oct. 25, 2014, 4:35 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26860/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 4:35 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. > > > Bugs: MESOS-1889 > https://issues.apache.org/jira/browse/MESOS-1889 > > > Repository: mesos-git > > > Description > ------- > > The CRAM-MD5 authenticator module is now usable via mesos-tests.sh > > Example usage: > bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5 --modules="{\"libraries\": [{\"file\": \"src/.libs/libauthentication_crammd5.so\",\"modules\": [{\"name\": \"org_apache_mesos_authenticator_crammd5\"}]}]}" > > > Diffs > ----- > > src/tests/flags.hpp 80f0cee > src/tests/mesos.cpp bff10d2 > > Diff: https://reviews.apache.org/r/26860/diff/ > > > Testing > ------- > > make check > > bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5 --modules="{\"libraries\": [{\"file\": \"src/.libs/libauthentication_crammd5.dylib\",\"modules\": [{\"name\": \"org_apache_mesos_authenticator_crammd5\"}]}]}" --verbose --gtest_filter="AuthenticationTest.AuthenticatedSlave" > > Shows: > I1024 06:16:14.764703 298631168 master.cpp:3874] Using 'org_apache_mesos_authenticator_crammd5' authenticator > > bin/mesos-tests.sh --verbose --gtest_filter="AuthenticationTest.AuthenticatedSlave" > > Shows: > I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5 authenticator > > > Thanks, > > Till Toenshoff > > --===============6625231631856088386==--