Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 64E2D102DE for ; Fri, 24 Oct 2014 03:14:42 +0000 (UTC) Received: (qmail 35187 invoked by uid 500); 24 Oct 2014 03:14:42 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 35105 invoked by uid 500); 24 Oct 2014 03:14:42 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 35081 invoked by uid 99); 24 Oct 2014 03:14:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Oct 2014 03:14:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 502431DF623; Fri, 24 Oct 2014 03:14:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2383009413311892263==" MIME-Version: 1.0 Subject: Re: Review Request 27113: Libprocess benchmark cleanup From: "Joris Van Remoortere" To: "Niklas Nielsen" , "Ben Mahler" Cc: "Joris Van Remoortere" , "mesos" , "Dominic Hamon" Date: Fri, 24 Oct 2014 03:14:46 -0000 Message-ID: <20141024031446.1282.71785@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/27113/ X-Sender: "Joris Van Remoortere" References: <20141023221837.1283.33453@reviews.apache.org> In-Reply-To: <20141023221837.1283.33453@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos-git --===============2383009413311892263== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 23, 2014, 10:18 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp, lines 40-53 > > > > > > I think we need to follow the same pattern as the mesos benchmarks, that is, they are included within the test binary, not as separate mains. The problem with including this in the regular libprocess test suite is that we require libprocess to be initialized after the forks have been instantiated. Once we can safely terminate the global libprocess state, we could merge this with the regular tests, until then it needs to be in a separate binary (or forcibly run before the other tests). - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/#review58124 ----------------------------------------------------------- On Oct. 24, 2014, 3:09 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27113/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 3:09 a.m.) > > > Review request for mesos, Ben Mahler and Niklas Nielsen. > > > Bugs: MESOS-1980 > https://issues.apache.org/jira/browse/MESOS-1980 > > > Repository: mesos-git > > > Description > ------- > > Add a comment to BenchmarkProcess. > Remove setLink() as it is not strictly necessary. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/benchmarks.cpp 79a650b > > Diff: https://reviews.apache.org/r/27113/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > > --===============2383009413311892263==--