Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43CBD175A5 for ; Wed, 22 Oct 2014 00:46:21 +0000 (UTC) Received: (qmail 39523 invoked by uid 500); 22 Oct 2014 00:46:21 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 39452 invoked by uid 500); 22 Oct 2014 00:46:21 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 39433 invoked by uid 99); 22 Oct 2014 00:46:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Oct 2014 00:46:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 997AC1DF539; Wed, 22 Oct 2014 00:46:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1674436793697912391==" MIME-Version: 1.0 Subject: Re: Review Request 26862: Fix docker flaky tests From: "Timothy Chen" To: "Benjamin Hindman" Cc: "Mesos ReviewBot" , "Timothy Chen" , "mesos" Date: Wed, 22 Oct 2014 00:46:25 -0000 Message-ID: <20141022004625.1282.12231@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26862/ X-Sender: "Timothy Chen" References: <20141022004249.1282.34729@reviews.apache.org> In-Reply-To: <20141022004249.1282.34729@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: mesos-git --===============1674436793697912391== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ ----------------------------------------------------------- (Updated Oct. 22, 2014, 12:46 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description ------- Docker tests are flaky, mostly around getting expected output from the docker container forwarded to stdout/stderr. This is due to Docker not always have the stdout/stderr output available for docker logs if kill/rm is called. Diffs (updated) ----- src/docker/docker.hpp 9656f15 src/docker/docker.cpp e09b51c src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 src/tests/docker_tests.cpp 04139af src/tests/environment.cpp 4dd78e7 Diff: https://reviews.apache.org/r/26862/diff/ Testing ------- make with gtest_repeat=-1 gtest_shuffle=1 Thanks, Timothy Chen --===============1674436793697912391==--