Return-Path: 
 <dev-return-33195-apmail-mesos-dev-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-dev-archive@www.apache.org
Delivered-To: apmail-mesos-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4BC8A17868
	for <apmail-mesos-dev-archive@www.apache.org>;
 Mon, 20 Oct 2014 22:53:38 +0000 (UTC)
Received: (qmail 72188 invoked by uid 500); 20 Oct 2014 22:53:38 -0000
Delivered-To: apmail-mesos-dev-archive@mesos.apache.org
Received: (qmail 72127 invoked by uid 500); 20 Oct 2014 22:53:38 -0000
Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@mesos.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@mesos.apache.org>
List-Post: <mailto:dev@mesos.apache.org>
List-Id: <dev.mesos.apache.org>
Reply-To: dev@mesos.apache.org
Delivered-To: mailing list dev@mesos.apache.org
Received: (qmail 72112 invoked by uid 99); 20 Oct 2014 22:53:37 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Oct 2014 22:53:37 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id DD25C1DF48A;
	Mon, 20 Oct 2014 22:53:42 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============5136072205992954998=="
MIME-Version: 1.0
Subject: Review Request 26955: Created a Result(Try&) constructor for
 Result<T>.
From: "Kapil Arya" <kapil@mesosphere.io>
To: "Niklas Nielsen" <nik@qni.dk>, "Benjamin Hindman" <benh@berkeley.edu>
Cc: "mesos" <dev@mesos.apache.org>, "Kapil Arya" <kapil@mesosphere.io>
Date: Mon, 20 Oct 2014 22:53:42 -0000
Message-ID: <20141020225342.1282.29457@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Kapil Arya" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/26955/
X-Sender: "Kapil Arya" <noreply@reviews.apache.org>
Reply-To: "Kapil Arya" <kapil@mesosphere.io>
X-ReviewRequest-Repository: mesos-git

--===============5136072205992954998==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26955/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description
-------

Try<T> doesn't have a default constructor and so it's not possible to have
a Try<T> class member variable  unless we initialize it with
Error().

With this patch, we can instead have a Result<T> class member variable
which is initialized to None() and can be assigned a Try<T> type.


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 256df0bb5557ebe6c75099d35c284804c9e57253 
  3rdparty/libprocess/3rdparty/stout/Makefile.am 125b3fad35674e5198c9119d19972635a468a0c8 
  3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 631f126ff2fee6e536056602ea5be0fe89837094 
  3rdparty/libprocess/3rdparty/stout/tests/result_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/26955/diff/


Testing
-------

Added result_tests.cpp and ran make check.


Thanks,

Kapil Arya


--===============5136072205992954998==--