Return-Path: 
 <dev-return-33148-apmail-mesos-dev-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-dev-archive@www.apache.org
Delivered-To: apmail-mesos-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 00F3417620
	for <apmail-mesos-dev-archive@www.apache.org>;
 Mon, 20 Oct 2014 04:53:44 +0000 (UTC)
Received: (qmail 38420 invoked by uid 500); 20 Oct 2014 04:53:43 -0000
Delivered-To: apmail-mesos-dev-archive@mesos.apache.org
Received: (qmail 38350 invoked by uid 500); 20 Oct 2014 04:53:43 -0000
Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@mesos.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@mesos.apache.org>
List-Post: <mailto:dev@mesos.apache.org>
List-Id: <dev.mesos.apache.org>
Reply-To: dev@mesos.apache.org
Delivered-To: mailing list dev@mesos.apache.org
Received: (qmail 38333 invoked by uid 99); 20 Oct 2014 04:53:43 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Oct 2014 04:53:43 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 97A7D1DF45E;
	Mon, 20 Oct 2014 04:53:38 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============1447895948427047441=="
MIME-Version: 1.0
Subject: Re: Review Request 26862: Fix docker flaky tests
From: "Benjamin Hindman" <benh@berkeley.edu>
To: "Benjamin Hindman" <benh@berkeley.edu>
Cc: "Timothy Chen" <tnachen@apache.org>, "mesos" <dev@mesos.apache.org>
Date: Mon, 20 Oct 2014 04:53:38 -0000
Message-ID: <20141020045338.16887.70727@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Benjamin Hindman" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/26862/
X-Sender: "Benjamin Hindman" <noreply@reviews.apache.org>
References: <20141017193325.30953.51490@reviews.apache.org>
In-Reply-To: <20141017193325.30953.51490@reviews.apache.org>
Reply-To: "Benjamin Hindman" <benh@berkeley.edu>
X-ReviewRequest-Repository: mesos-git

--===============1447895948427047441==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26862/#review57308
-----------------------------------------------------------



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26862/#comment97984>

    Feel free to just have 'create' return an Owned<Docker> too.



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26862/#comment97985>

    Feel free to just have 'create' return an Owned<Docker> too. I know that is not consistent throughout the codebase but it would be great to move in that direction.



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26862/#comment97987>

    Can we put this back in the review for scheduling the container removal?



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26862/#comment97988>

    But it's not really owned!



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26862/#comment97989>

    Why are we removing the Docker container? Isn't this test making sure that it gets removed without us doing this already!?



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26862/#comment97990>

    I think we should be checking whether or not the container is actually running here. That's a fundamental part of these tests IIUC!



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/26862/#comment97991>

    Let's do this right and set up EXPECT_CALLs like we do with other mocks. :-)


- Benjamin Hindman


On Oct. 17, 2014, 7:33 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26862/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 7:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Docker tests are flaky, mostly around getting expected output from the docker container forwarded to stdout/stderr.
> 
> This is due to Docker not always have the stdout/stderr output available for docker logs if kill/rm is called.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9656f15 
>   src/docker/docker.cpp e09b51c 
>   src/slave/containerizer/docker.hpp fbbd45d 
>   src/slave/containerizer/docker.cpp 9a29489 
>   src/tests/docker_containerizer_tests.cpp 67d60a8 
>   src/tests/docker_tests.cpp 04139af 
>   src/tests/environment.cpp 4dd78e7 
> 
> Diff: https://reviews.apache.org/r/26862/diff/
> 
> 
> Testing
> -------
> 
> make with gtest_repeat=-1 gtest_shuffle=1
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


--===============1447895948427047441==--