Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF63B17AB9 for ; Fri, 17 Oct 2014 19:57:06 +0000 (UTC) Received: (qmail 14121 invoked by uid 500); 17 Oct 2014 19:57:06 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 14056 invoked by uid 500); 17 Oct 2014 19:57:06 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 14040 invoked by uid 99); 17 Oct 2014 19:57:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Oct 2014 19:57:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B88DB1DF430; Fri, 17 Oct 2014 19:57:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2942426297025186850==" MIME-Version: 1.0 Subject: Re: Review Request 26817: Split authorization from task validation. From: "Ben Mahler" To: "Vinod Kone" , "Ben Mahler" Cc: "mesos" , "Dominic Hamon" Date: Fri, 17 Oct 2014 19:57:01 -0000 Message-ID: <20141017195701.30984.96361@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26817/ X-Sender: "Ben Mahler" References: <20141017195326.30953.55569@reviews.apache.org> In-Reply-To: <20141017195326.30953.55569@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos-git --===============2942426297025186850== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26817/#review57202 ----------------------------------------------------------- Hm.. could you please split the code movement out into a separate change so that it's easier to see what you're changing here? Hard to see what's changed inside within the continuation since it's been moved as well. - Ben Mahler On Oct. 17, 2014, 7:53 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26817/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 7:53 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > split authorization from task validation. allows https://reviews.apache.org/r/26382/ to differentiate between validation issues and task authorization issues. > > also replaced some > > with >> and changed the order of methods in the cpp to match the continuation order. > > > Diffs > ----- > > src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205 > src/master/master.cpp 1b1ce0de3065ced45890777d42c69ef1091f5699 > > Diff: https://reviews.apache.org/r/26817/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > > --===============2942426297025186850==--