Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAC3217AF3 for ; Thu, 16 Oct 2014 06:33:31 +0000 (UTC) Received: (qmail 83328 invoked by uid 500); 16 Oct 2014 06:33:31 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 83262 invoked by uid 500); 16 Oct 2014 06:33:31 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 83248 invoked by uid 99); 16 Oct 2014 06:33:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 06:33:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 02BEE1DDDC6; Thu, 16 Oct 2014 06:33:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7782076111337822651==" MIME-Version: 1.0 Subject: Re: Review Request 26674: Added "name" to Modules protobuf. From: "Mesos ReviewBot" To: "Niklas Nielsen" , "Benjamin Hindman" Cc: "Mesos ReviewBot" , "mesos" , "Kapil Arya" Date: Thu, 16 Oct 2014 06:33:27 -0000 Message-ID: <20141016063327.24426.34025@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26674/ X-Sender: "Mesos ReviewBot" References: <20141016015744.24426.63688@reviews.apache.org> In-Reply-To: <20141016015744.24426.63688@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============7782076111337822651== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26674/#review56900 ----------------------------------------------------------- Patch looks great! Reviews applied: [26674] All tests passed. - Mesos ReviewBot On Oct. 16, 2014, 1:57 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26674/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 1:57 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > To allow the users to specify a bare library names. > > For example, "foo-2.3" will expand to "libfoo-2.3.so" on Linux and "libfoo-2.3.dylib" on OS X. > > > Diffs > ----- > > src/master/flags.hpp c41af1f4b1671d121eb617327086f5d80a2ba083 > src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99 > src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 > src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 > src/slave/flags.hpp 159d4ef63643d17be353533992049a38aec72437 > src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 > > Diff: https://reviews.apache.org/r/26674/diff/ > > > Testing > ------- > > Added a new test and ran make check. > > > Thanks, > > Kapil Arya > > --===============7782076111337822651==--