Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 57C9617305 for ; Thu, 16 Oct 2014 00:18:34 +0000 (UTC) Received: (qmail 72788 invoked by uid 500); 16 Oct 2014 00:18:34 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 72718 invoked by uid 500); 16 Oct 2014 00:18:34 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 72687 invoked by uid 99); 16 Oct 2014 00:18:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2014 00:18:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6D4281DDFAD; Thu, 16 Oct 2014 00:18:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8035004634629256417==" MIME-Version: 1.0 Subject: Re: Review Request 26789: Allow unloading a single module. From: "Kapil Arya" To: "Niklas Nielsen" , "Till Toenshoff" Cc: "mesos" , "Kapil Arya" Date: Thu, 16 Oct 2014 00:18:29 -0000 Message-ID: <20141016001829.24426.67780@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26789/ X-Sender: "Kapil Arya" References: <20141016001016.24413.7494@reviews.apache.org> In-Reply-To: <20141016001016.24413.7494@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos-git --===============8035004634629256417== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ ----------------------------------------------------------- (Updated Oct. 15, 2014, 8:18 p.m.) Review request for mesos, Niklas Nielsen and Till Toenshoff. Changes ------- Updated description. Repository: mesos-git Description (updated) ------- Also removed the existing unloadAll() that is no longer needed. unloadAll() forces destruction of Owned pointers to the dynamic library handle. This implicitly causes a dlclose() of all the loaded module libraries. However, in certain situations (e.g. OS X), dlclose() is not ideal due to its side-effects. Diffs ----- src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 Diff: https://reviews.apache.org/r/26789/diff/ Testing ------- make check. Thanks, Kapil Arya --===============8035004634629256417==--