Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D59F517CDF for ; Wed, 15 Oct 2014 21:51:20 +0000 (UTC) Received: (qmail 73609 invoked by uid 500); 15 Oct 2014 21:51:15 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 73535 invoked by uid 500); 15 Oct 2014 21:51:15 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 73514 invoked by uid 99); 15 Oct 2014 21:51:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 21:51:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EAD4E1DF30F; Wed, 15 Oct 2014 21:51:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4173622521127836380==" MIME-Version: 1.0 Subject: Re: Review Request 25549: Basic filesystem isolator for Linux. From: "Timothy Chen" To: "Vinod Kone" , "Ben Mahler" , "Jie Yu" Cc: "mesos" , "Timothy Chen" , "Ian Downes" Date: Wed, 15 Oct 2014 21:51:10 -0000 Message-ID: <20141015215110.24414.84743@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/25549/ X-Sender: "Timothy Chen" References: <20141015192556.24414.74083@reviews.apache.org> In-Reply-To: <20141015192556.24414.74083@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: mesos-git --===============4173622521127836380== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25549/#review56823 ----------------------------------------------------------- Ship it! Ship It! - Timothy Chen On Oct. 15, 2014, 7:25 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25549/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 7:25 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-1586 > https://issues.apache.org/jira/browse/MESOS-1586 > > > Repository: mesos-git > > > Description > ------- > > Does not report usage or enforce quota but can create 'private' directories for each container which mask parts of the shared host filesystem. > > This review replaces https://reviews.apache.org/r/24178/ because of some file renaming. I addressed all comments from earlier reviews. > > > Diffs > ----- > > include/mesos/mesos.proto 6b93e9000761857c4f335f2a8c8088e155078f54 > src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 > src/common/parse.hpp c9ca30fde5580d8e388f3c616e78df2b032ac0ad > src/common/type_utils.hpp f10b2d31f2781bd056898f93eb8e8b6d9809e80b > src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b > src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > src/slave/slave.cpp 0e342ed35e3db3b68f9f32b6cf4ace23e4a4db38 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 > > Diff: https://reviews.apache.org/r/25549/diff/ > > > Testing > ------- > > make check # added a test > > > Thanks, > > Ian Downes > > --===============4173622521127836380==--