Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B0E117C98 for ; Tue, 14 Oct 2014 17:10:34 +0000 (UTC) Received: (qmail 40144 invoked by uid 500); 14 Oct 2014 17:10:34 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 40057 invoked by uid 500); 14 Oct 2014 17:10:34 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 39941 invoked by uid 99); 14 Oct 2014 17:10:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Oct 2014 17:10:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B0D481DDF40; Tue, 14 Oct 2014 17:10:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5223135066459723865==" MIME-Version: 1.0 Subject: Re: Review Request 21277: Passed CommandInfo to mesos-fetcher as JSON. From: "Niklas Nielsen" To: "Tom Arnfeld" , "Dominic Hamon" , "Ben Mahler" Cc: "Niklas Nielsen" , "Benjamin Hindman" , "mesos" Date: Tue, 14 Oct 2014 17:10:29 -0000 Message-ID: <20141014171029.24414.42755@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Niklas Nielsen" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/21277/ X-Sender: "Niklas Nielsen" References: <20140509190504.3852.97844@reviews.apache.org> In-Reply-To: <20140509190504.3852.97844@reviews.apache.org> Reply-To: "Niklas Nielsen" X-ReviewRequest-Repository: mesos-git --===============5223135066459723865== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21277/#review56549 ----------------------------------------------------------- LGTM but needs rebase. Would be sweet to get in: much more robust than magic encoding :-) - Niklas Nielsen On May 9, 2014, 12:05 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21277/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 12:05 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Tom Arnfeld. > > > Bugs: MESOS-1248 > https://issues.apache.org/jira/browse/MESOS-1248 > > > Repository: mesos-git > > > Description > ------- > > See summary (and bug). > > > Diffs > ----- > > src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 > src/slave/fetcher.hpp PRE-CREATION > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21277/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > > --===============5223135066459723865==--