Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37D8317AC7 for ; Sat, 11 Oct 2014 00:10:11 +0000 (UTC) Received: (qmail 69820 invoked by uid 500); 11 Oct 2014 00:10:11 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 69756 invoked by uid 500); 11 Oct 2014 00:10:11 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 69660 invoked by uid 99); 11 Oct 2014 00:10:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Oct 2014 00:10:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A515C1DDD94; Sat, 11 Oct 2014 00:10:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0070975732934344150==" MIME-Version: 1.0 Subject: Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process From: "Mesos ReviewBot" To: "Niklas Nielsen" , "Benjamin Hindman" Cc: "Joris Van Remoortere" , "Mesos ReviewBot" , "mesos" Date: Sat, 11 Oct 2014 00:10:06 -0000 Message-ID: <20141011001006.24817.90802@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26583/ X-Sender: "Mesos ReviewBot" References: <20141010231238.24818.74091@reviews.apache.org> In-Reply-To: <20141010231238.24818.74091@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============0070975732934344150== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review56261 ----------------------------------------------------------- Bad patch! Reviews applied: [26578, 26580, 26583] Failed command: git apply --index 26583.patch Error: error: patch failed: 3rdparty/libprocess/src/process.cpp:1690 error: 3rdparty/libprocess/src/process.cpp: patch does not apply - Mesos ReviewBot On Oct. 10, 2014, 11:12 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26583/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 11:12 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Wrap the libprocess garbage collector process with a unique ptr. Reset the ptr during finalization. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 85fb995 > > Diff: https://reviews.apache.org/r/26583/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > > --===============0070975732934344150==--