Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C01EB17341 for ; Fri, 10 Oct 2014 20:48:33 +0000 (UTC) Received: (qmail 98071 invoked by uid 500); 10 Oct 2014 20:48:33 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 97999 invoked by uid 500); 10 Oct 2014 20:48:33 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 97979 invoked by uid 99); 10 Oct 2014 20:48:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Oct 2014 20:48:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2CED31DDE70; Fri, 10 Oct 2014 20:48:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8602151764420623318==" MIME-Version: 1.0 Subject: Re: Review Request 26274: Remove /proc and /sys remounts from port_mapping isolator. From: "Ian Downes" To: "Vinod Kone" , "Jie Yu" Cc: "Mesos ReviewBot" , "mesos" , "Ian Downes" Date: Fri, 10 Oct 2014 20:48:29 -0000 Message-ID: <20141010204829.24817.57961@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ian Downes" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/26274/ X-Sender: "Ian Downes" References: <20141002181724.18846.89260@reviews.apache.org> In-Reply-To: <20141002181724.18846.89260@reviews.apache.org> Reply-To: "Ian Downes" X-ReviewRequest-Repository: mesos-git --===============8602151764420623318== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26274/ ----------------------------------------------------------- (Updated Oct. 10, 2014, 1:48 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Changes ------- Corrected a comment. Bugs: MESOS-1853 https://issues.apache.org/jira/browse/MESOS-1853 Repository: mesos-git Description ------- Remove /proc and /sys remounts from port_mapping isolator. See ticket for details. Diffs (updated) ----- src/slave/containerizer/isolators/network/port_mapping.cpp 8ddfb1817d78c45ce2f6daebbeb13d380998ee4d src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b Diff: https://reviews.apache.org/r/26274/diff/ Testing ------- Thanks, Ian Downes --===============8602151764420623318==--