Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============2248806952661252316=="
MIME-Version: 1.0
Subject: Re: Review Request 26247: Remove usage of <stout/preprocessor.hpp>
 from mesos.
From: "Mesos ReviewBot" <dev@mesos.apache.org>
To: "Dominic Hamon" <dhamon@twopensource.com>
Cc: "Mesos ReviewBot" <dev@mesos.apache.org>, "mesos" <dev@mesos.apache.org>,
 "Michael Park" <mcypark@gmail.com>
Date: Sun, 05 Oct 2014 07:19:02 -0000
Message-ID: <20141005071902.12762.87223@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
References: <20141005070846.12760.83559@reviews.apache.org>
In-Reply-To: <20141005070846.12760.83559@reviews.apache.org>
Reply-To: "Mesos ReviewBot" <dev@mesos.apache.org>

--===============2248806952661252316==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26247/#review55469
-----------------------------------------------------------


Bad patch!

Reviews applied: [26245, 26245]

Failed command: git apply --index 26245.patch

Error:
 error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am:27
error: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp:23
error: 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp:21
error: 3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp: patch does not apply
error: 3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp: does not exist in index
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp:1
error: 3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp:1
error: 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp:24
error: 3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp:4
error: 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp: patch does not apply

- Mesos ReviewBot


On Oct. 5, 2014, 7:08 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26247/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2014, 7:08 a.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> These are changes necessary from removing `<stout/preprocessor.hpp>` from `stout` and `libprocess`.
> With the preprocessor expansion, taking the address of an overloaded function was disambiguated by the number of arguments.
> The number of arguments a function takes is not a reliable disambiguation mechanism, we `static_cast` them to a specific signature as we do in other parts of the code where disambiguation of overloaded functions is necessary.
> 
> 
> Diffs
> -----
> 
>   src/log/log.cpp b3c6c20d734ea82d8531217d53decf1707183565 
>   src/log/replica.cpp c18de86f2659b848b0e8f0468e4efa820d048970 
>   src/master/allocator.hpp 02d20d0cc802805bc702891306aa42894531b223 
>   src/scheduler/scheduler.cpp fb88a3e029e97ba33eae5d50503be5ed9c9533e6 
>   src/slave/containerizer/composing.cpp 9022700b628d9746a6a8a17c9fbf1b1988da6fca 
>   src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
>   src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c 
>   src/slave/status_update_manager.cpp 5d5cf234ef2dd47fa4b1f67be761dbca31659451 
>   src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 
>   src/zookeeper/zookeeper.cpp d4c24cd500b74d3b979a471b4a32def78958f04a 
> 
> Diff: https://reviews.apache.org/r/26247/diff/
> 
> 
> Testing
> -------
> 
> `make && make check` on `gcc-4.4`, `gcc-4.6`, `gcc-4.8`, `gcc-4.9`, `clang-3.3` and `clang-3.5`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


--===============2248806952661252316==--