mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 26486: Fix containerizer not receiving destroy/update calls when launching.
Date Fri, 31 Oct 2014 15:57:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26486/#review59350
-----------------------------------------------------------

Ship it!



src/slave/containerizer/composing.cpp
<https://reviews.apache.org/r/26486/#comment100620>

    Move update to previous line and wrap after '(' please.


- Benjamin Hindman


On Oct. 21, 2014, 4:42 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26486/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 4:42 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1884 and MESOS-1915
>     https://issues.apache.org/jira/browse/MESOS-1884
>     https://issues.apache.org/jira/browse/MESOS-1915
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/26486
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 
>   src/slave/containerizer/composing.cpp 9022700b628d9746a6a8a17c9fbf1b1988da6fca 
>   src/tests/composing_containerizer_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26486/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message