mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 27175: Added support for handling 'rc' tag to Version.
Date Thu, 30 Oct 2014 21:25:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27175/#review59259
-----------------------------------------------------------


Patch looks great!

Reviews applied: [27175]

All tests passed.

- Mesos ReviewBot


On Oct. 30, 2014, 8:32 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27175/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 8:32 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1987
>     https://issues.apache.org/jira/browse/MESOS-1987
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Now it can parse strings like "1.2.3-rc4". Other tags are still
> discarded.
> 
> Updated os::release() to use Version::parse() instead of sscanf.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab

>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 090fcf09dd96538a8748cf4443d150911e2c0d27

>   3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp e8f8358f3c113b4e21e30cb5e9d6a3d229191484

> 
> Diff: https://reviews.apache.org/r/27175/diff/
> 
> 
> Testing
> -------
> 
> Enhanced version tests and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message