mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.
Date Sat, 25 Oct 2014 23:40:40 GMT


> On Oct. 13, 2014, 4:25 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 271
> > <https://reviews.apache.org/r/26634/diff/1/?file=719342#file719342line271>
> >
> >     this should return an Error to indicate out of bounds access attempt.

I choose to return None instead.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26634/#review56405
-----------------------------------------------------------


On Oct. 25, 2014, 11:40 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26634/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2014, 11:40 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 2e1f78e509b4270bdf33c50f5bca59bca4cb1bc4

>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e639185323a3809ca82c09428b3b1b8afe5

> 
> Diff: https://reviews.apache.org/r/26634/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message