mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 27166: Correctly recover pid in Linux launcher.
Date Fri, 24 Oct 2014 23:55:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27166/#review58446
-----------------------------------------------------------

Ship it!



src/slave/containerizer/linux_launcher.cpp
<https://reviews.apache.org/r/27166/#comment99463>

    Should we have a small note similar to your review description?


- Ben Mahler


On Oct. 24, 2014, 9:54 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27166/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 9:54 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> If the freezer cgroup is absent (if the slave terminates after the
> cgroup is destroyed but before realizing) we should still recover the
> pid because we check this on destroy().
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b

> 
> Diff: https://reviews.apache.org/r/27166/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message