mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 27113: Libprocess benchmark cleanup
Date Fri, 24 Oct 2014 03:14:46 GMT


> On Oct. 23, 2014, 10:18 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/tests/benchmarks.cpp, lines 40-53
> > <https://reviews.apache.org/r/27113/diff/1/?file=731328#file731328line40>
> >
> >     I think we need to follow the same pattern as the mesos benchmarks, that is,
they are included within the test binary, not as separate mains.

The problem with including this in the regular libprocess test suite is that we require libprocess
to be initialized after the forks have been instantiated. Once we can safely terminate the
global libprocess state, we could merge this with the regular tests, until then it needs to
be in a separate binary (or forcibly run before the other tests).


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27113/#review58124
-----------------------------------------------------------


On Oct. 24, 2014, 3:09 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27113/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 3:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Niklas Nielsen.
> 
> 
> Bugs: MESOS-1980
>     https://issues.apache.org/jira/browse/MESOS-1980
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add a comment to BenchmarkProcess.
> Remove setLink() as it is not strictly necessary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 79a650b 
> 
> Diff: https://reviews.apache.org/r/27113/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message