mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 27116: Fix Libprocess benchmark OSX
Date Thu, 23 Oct 2014 23:24:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27116/#review58167
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Oct. 23, 2014, 11:17 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27116/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 11:17 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> pipe2 does not work on osx. 
> Replace with a helper function that sets up the pipes using pipe() and then stout/os::cloexec().
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 79a650b 
> 
> Diff: https://reviews.apache.org/r/27116/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message