mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 26906: Check "kind" before creating a module instance.
Date Wed, 22 Oct 2014 16:23:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26906/#review57808
-----------------------------------------------------------



src/examples/test_module.hpp
<https://reviews.apache.org/r/26906/#comment98677>

    Why not just return the string directly?
    
    return "TestModule"



src/module/manager.hpp
<https://reviews.apache.org/r/26906/#comment98679>

    Why this change? because of 'kind<Kind>'?



src/module/manager.hpp
<https://reviews.apache.org/r/26906/#comment98678>

    Much better! :)


- Niklas Nielsen


On Oct. 22, 2014, 1:04 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26906/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 1:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Since, there is no reliable method of converting a template type to a
> string, we create an temporary object of the given kind and compare the
> "kind" fields of the temporary object with that of the one being
> created.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module.hpp 5205e30c7b8228eced9793aef2348930180811bb 
>   src/examples/test_module.hpp b5cc2fa9147c4fe9a1f2eb3e8c2c2565ea7f7420 
>   src/module/manager.hpp 1c93ac4707e3c5dc8acaaa23861b62d3d3921125 
>   src/tests/module_tests.cpp e92d8717427e259b1fa26b3f17719fd616a748c7 
> 
> Diff: https://reviews.apache.org/r/26906/diff/
> 
> 
> Testing
> -------
> 
> Added a new test and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message