mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 26817: Split authorization from task validation.
Date Tue, 21 Oct 2014 18:49:42 GMT


> On Oct. 20, 2014, 5:56 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 2546
> > <https://reviews.apache.org/r/26817/diff/4/?file=725867#file725867line2546>
> >
> >     I think now you can just do foreach on authorizations now?
> 
> Vinod Kone wrote:
>     dropped without comment?

i don't think so - i need the index for the tasks, the validations, and the authorizations.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26817/#review57489
-----------------------------------------------------------


On Oct. 21, 2014, 10:39 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26817/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 10:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> split authorization from task validation. allows https://reviews.apache.org/r/26382/
to differentiate between validation issues and task authorization issues.
> 
> also replaced some > > with >> and changed the order of methods in the cpp
to match the continuation order.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 14f1d0fd240c9cd0718d0238e1fbb9c733190205 
>   src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4 
> 
> Diff: https://reviews.apache.org/r/26817/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message