mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 26855: Added setup/teardown for module API tests.
Date Tue, 21 Oct 2014 01:09:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26855/#review57510
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Oct. 20, 2014, 5:52 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26855/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2014, 5:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1940
>     https://issues.apache.org/jira/browse/MESOS-1940
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> During the one-time setup of the test cases, we do the following:
> 1. set LD_LIBRARY_PATH to also point to the src/.libs directory.
>    The original LD_LIBRARY_PATH is restored at the end of all tests.
> 2. dlopen() examplemodule library and retrieve the pointer to 
>    ModuleBase for the test module.  This pointer is later used to
>    reset the Mesos and module API versions during per-test teardown.
> 
> During the tear-down after each test, we unload the module to allow
> later loads to succeed.
> 
> 
> Diffs
> -----
> 
>   src/examples/example_module_impl.cpp 27c05201a53de3efb00846e694db41cfe9250e61 
>   src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 
> 
> Diff: https://reviews.apache.org/r/26855/diff/
> 
> 
> Testing
> -------
> 
> make check with and without shuffle with repeated iterations.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message