mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 26846: Updated status update manager to forward updates via slave.
Date Mon, 20 Oct 2014 23:48:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26846/
-----------------------------------------------------------

(Updated Oct. 20, 2014, 11:48 p.m.)


Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen.


Changes
-------

addressed comments.


Repository: mesos-git


Description
-------

All the updates from the status update manager are funnelled via the slave. No more sending
updates in the middle of recovery or disconnection. Yay.

Had to cleanup flags.recover = "cleanup" semantics because the updates are no longer sent
when the slave is disconnected. 


Diffs (updated)
-----

  src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4 
  src/slave/slave.hpp ccc0e03edbd41d9ce3bb0f6b0447bf4240648986 
  src/slave/slave.cpp 7b5474ae898f369fc55670cf1dbbee684bc0ae4b 
  src/slave/status_update_manager.hpp c371e5542e12cd6bb9401591cd691d99bc0fa8fd 
  src/slave/status_update_manager.cpp 5d5cf234ef2dd47fa4b1f67be761dbca31659451 
  src/tests/slave_recovery_tests.cpp 4fb357bd55f69f71193e92fd03765b808f932d33 

Diff: https://reviews.apache.org/r/26846/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message