mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "R.B. Boyer" <boyers...@nexusvector.net>
Subject Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user
Date Sat, 18 Oct 2014 22:14:03 GMT


> On Oct. 18, 2014, 4:50 p.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, line 528
> > <https://reviews.apache.org/r/26894/diff/1/?file=724949#file724949line528>
> >
> >     Hm.. this doesn't look like the right usage of shell=false (which should use
the `arguments` field):
> >     
> >     https://github.com/apache/mesos/blob/0.20.1/include/mesos/mesos.proto#L238

FYI "shell=false" with arguments is broken until this is merged: https://reviews.apache.org/r/26622/


- R.B.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26894/#review57283
-----------------------------------------------------------


On Oct. 17, 2014, 5:49 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26894/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 5:49 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1359
>     https://issues.apache.org/jira/browse/MESOS-1359
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The 'nobody' user is restricted on some systems from shell access and broke the task.user
tests (which have been disabled since then).
> With the command.shell field, the test can run the command directly.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp a1bd1d4 
> 
> Diff: https://reviews.apache.org/r/26894/diff/
> 
> 
> Testing
> -------
> 
> make check on linux as root
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message