mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Review Request 26906: Check "kind" before creating a module instance.
Date Sat, 18 Oct 2014 01:58:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26906/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description
-------

Since, there is no reliable method of converting a template type to a
string, we create an temporary object of the given kind and compare the
"kind" fields of the temporary object with that of the one being
created.


Diffs
-----

  src/module/manager.hpp 56e2af334866d2736a8d43f45daf2dbf5189ce2d 
  src/tests/module_tests.cpp 54e1e8d26719069d01bfabd918f7c37ddbf3c7c4 

Diff: https://reviews.apache.org/r/26906/diff/


Testing
-------

Added a new test and ran make check.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message