mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 26838: Fix module API version tests.
Date Thu, 16 Oct 2014 23:16:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26838/#review57038
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Oct. 16, 2014, 4:13 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26838/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 4:13 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The tests were changing the Mesos API and library version without resetting back to the
valid string. This caused the subsequent tests to fail.  The fix is to reset the version after
the test is done.
> 
> 
> Diffs
> -----
> 
>   src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 
> 
> Diff: https://reviews.apache.org/r/26838/diff/
> 
> 
> Testing
> -------
> 
> Reproduced the test with --gtest_shuffle, and verified that the patch fixes the problem.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message