mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 26815: Added a advisory message reminding the user to initialize the log.
Date Thu, 16 Oct 2014 19:13:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26815/#review56976
-----------------------------------------------------------

Ship it!



src/log/recover.cpp
<https://reviews.apache.org/r/26815/#comment97411>

    Great! Maybe wrap it with a header / footer since it is advisory?
    
    ```
    ------------------------------------------------
    Blah blah blah
    ------------------------------------------------
    ```


- Ben Mahler


On Oct. 16, 2014, 7:11 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26815/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 7:11 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Vinod Kone, and Bill Farner.
> 
> 
> Bugs: MESOS-1703
>     https://issues.apache.org/jira/browse/MESOS-1703
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See ticket for details.
> 
> 
> Diffs
> -----
> 
>   src/log/recover.cpp 2013e9193fc53c769ec6815d769cdf8a565a8c5c 
> 
> Diff: https://reviews.apache.org/r/26815/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message