mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 26674: Added "name" to Modules protobuf.
Date Thu, 16 Oct 2014 06:33:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26674/#review56900
-----------------------------------------------------------


Patch looks great!

Reviews applied: [26674]

All tests passed.

- Mesos ReviewBot


On Oct. 16, 2014, 1:57 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26674/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 1:57 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> To allow the users to specify a bare library names.
> 
> For example, "foo-2.3" will expand to "libfoo-2.3.so" on Linux and "libfoo-2.3.dylib"
on OS X.
> 
> 
> Diffs
> -----
> 
>   src/master/flags.hpp c41af1f4b1671d121eb617327086f5d80a2ba083 
>   src/messages/messages.proto 8de7f9699f43aa2780f4a39fed087abcf5e5af99 
>   src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 
>   src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 
>   src/slave/flags.hpp 159d4ef63643d17be353533992049a38aec72437 
>   src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 
> 
> Diff: https://reviews.apache.org/r/26674/diff/
> 
> 
> Testing
> -------
> 
> Added a new test and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message