mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 26766: MESOS-1878: Add additional helper functions to <stout/path>
Date Thu, 16 Oct 2014 05:01:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26766/#review56885
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
<https://reviews.apache.org/r/26766/#comment97323>

    I see, but I'm still not clear why we're fixing up /a/b///c/d into /a/b/c/d for the user
though?



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
<https://reviews.apache.org/r/26766/#comment97326>

    So I'm coming from this is a shared function that is applicable for all paths in Mesos,
and I won't really expect that "" == "/" in the path split, and assume I just get the directory
names in the vector.
    
    Do you need to keep this info for your files.cpp?



3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
<https://reviews.apache.org/r/26766/#comment97327>

    Why handle it specially here instead of just using the while below?


- Timothy Chen


On Oct. 15, 2014, 6:46 p.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26766/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 6:46 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-1878
>     https://issues.apache.org/jira/browse/MESOS-1878
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Adds 3 new functions: asAbsolute, clean, and split(). All three were hand-coded inside
of mesos files (files/files.cpp). This puts them in a common place, and adds unit tests for
their behavior.
> 
> The functions depend on eachother somewhat, so I pulled out the declarations to make
them all forward declared.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 357a75a8bac497465671456aa9cd9181123cc635

>   3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp aedf93573ea89e46bf7b7b91f2258049af2fd79f

> 
> Diff: https://reviews.apache.org/r/26766/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message