mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 26794: Install mesos git helper scripts on bootstrap
Date Thu, 16 Oct 2014 02:41:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26794/#review56867
-----------------------------------------------------------



bootstrap
<https://reviews.apache.org/r/26794/#comment97304>

    Are you sure this symlink works?
    
    IIRC, it had to be
    
    ln -s ../../support/hooks/pre-commit .git/hooks/pre-commit


- Vinod Kone


On Oct. 16, 2014, 2:32 a.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26794/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 2:32 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1932
>     https://issues.apache.org/jira/browse/MESOS-1932
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Installs .gitignore and the mesos pre-commit hook if they aren't already set. User-set
hooks will never be overridden.
> 
> 
> Diffs
> -----
> 
>   bootstrap 572755093f5a90115000f2829405462e3dd7accb 
> 
> Diff: https://reviews.apache.org/r/26794/diff/
> 
> 
> Testing
> -------
> 
> Ran bootstrap by hand, verified that it created the files as desired, didn't error when
run more than once, and didn't override user-provided files.
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message