mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 26723: Escape JSON object keys
Date Thu, 16 Oct 2014 01:32:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26723/#review56857
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp
<https://reviews.apache.org/r/26723/#comment97294>

    It looks like this could have been a one line change..?
    
    ```
    // We need to ensure the key is escaped by wrapping it in a String.
    out << "\"" << String((*iterator).first) << "\":" << (*iterator).second;
    ```


- Ben Mahler


On Oct. 15, 2014, 6 p.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26723/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 6 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-1878
>     https://issues.apache.org/jira/browse/MESOS-1878
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> All strings in JSON need to be escaped, including the keys in dictionaries / objects.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 719aa964a536cf02dbd2de440157de487ec703b1

> 
> Diff: https://reviews.apache.org/r/26723/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message