mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 26789: Allow unloading a single module.
Date Thu, 16 Oct 2014 00:18:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26789/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 8:18 p.m.)


Review request for mesos, Niklas Nielsen and Till Toenshoff.


Changes
-------

Updated description.


Repository: mesos-git


Description (updated)
-------

Also removed the existing unloadAll() that is no longer needed.

unloadAll() forces destruction of Owned pointers to the dynamic library handle.  This implicitly
causes a dlclose() of all the loaded module libraries.  However, in certain situations (e.g.
OS X), dlclose() is not ideal due to its side-effects.


Diffs
-----

  src/module/manager.hpp 797728a8c8e88dd1a13142a355cbe0b1491fb7a2 
  src/module/manager.cpp 8cc79956a8d3d7cb27016889ec59d138a0b58e45 
  src/tests/module_tests.cpp 71e7ef9ee9b21305528c00c7bfa2419ac9936974 

Diff: https://reviews.apache.org/r/26789/diff/


Testing
-------

make check.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message