mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 24341: Added Java replicated log implementation of State.
Date Wed, 15 Oct 2014 18:01:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24341/#review56625
-----------------------------------------------------------

Ship it!


Looks like you forgot to add the generated header in this patch.


src/Makefile.am
<https://reviews.apache.org/r/24341/#comment97012>

    Where is this file?



src/java/src/org/apache/mesos/state/LogState.java
<https://reviews.apache.org/r/24341/#comment97013>

    Ah, didn't realize that the State hierarchy in Java was different than in C++. I'm just
curious, was this for testing purposes, or?


- Ben Mahler


On Oct. 12, 2014, 4:14 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24341/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2014, 4:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 
>   src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION 
>   src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24341/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message