mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 26605: stout: Cleanup right angle bracket in the code base.
Date Wed, 15 Oct 2014 12:01:49 GMT


> On Oct. 13, 2014, 9:17 a.m., Till Toenshoff wrote:
> > Thanks for proposing this patch Evelina.
> > 
> > Could you please split this into seperate patches for stout, libprocess and mesos
itself?
> 
> Evelina Dumitrescu wrote:
>     What do you mean by three separate patches? I suppose three different commits ...
>     It is not very clear to me how to organize them. As far as I can see stout is included
in libprocess.
> 
> Till Toenshoff wrote:
>     Yes, three different review proposals / aka patches.

Done


- Evelina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26605/#review56383
-----------------------------------------------------------


On Oct. 15, 2014, 11:25 a.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26605/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 11:25 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Till Toenshoff.
> 
> 
> Bugs: MESOS-1872
>     https://issues.apache.org/jira/browse/MESOS-1872
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced > > with >> to be consistent with the C++ 11 standarad.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 37e007e9ee3010d9aacf2de6254abb75b716412d

>   3rdparty/libprocess/3rdparty/stout/include/stout/flags.hpp ab609a0d7922298eaf89648200fabd843f8201e0

>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp f4b7a95a8ca1e625c3dac7823f4db47f7b4f2c10

>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 89e77bf75c642c00ac9e0d36a3dbe71838e0efab

>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 719aa964a536cf02dbd2de440157de487ec703b1

>   3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp 89340fd79167a311c698740454db19e83c286952

>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec41fe412290a152a15a49e091f0bc6436e42cfd

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp fa1950cc8849fcd81d425c651848e05661111078

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 7a5573be8d8be537e5fd85b86e322fd5765c54ab

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp 7cd4a40f57a661d83d1726c65fd8c898072e809b

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 7d172494444cf1d14e9344112dd7fef7230c2ad8

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp e7fe077f763518680ba13d609dba9ea26950210d

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp 5278996f201a4a3d69282c1bd7b0d230d0f6cd39

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp a1e6e4d131e15c31135d72399e5e6825e7dd0141

>   3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp 0004fa5cd249269504155e51e52cd802c0916851

>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 3b30ab7ec93a94dc69b4c817a15a16317520fa74

>   3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 01e47ff21574d22f9469ab3bafd458322f6849c9

>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff824bada441cd657e10ca01762085a6d099

>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 79e720040e55de5aa68511d65cacf3952a57081a

>   3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e5d7c3770be4a5a39feea5a2f22179b871

>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c

>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 898d175980e397493270454aafdf340a96c9cf85

>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 56a63e8f5d809f03c70c60d4f02cc500d06ff96e

>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 4041dc47a12c9540dc8d23f083e783e68f0a1af8

>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp b90057972d22123d655697425581cc2767ec825d

> 
> Diff: https://reviews.apache.org/r/26605/diff/
> 
> 
> Testing
> -------
> 
> make check
> run grep -Hnr "> >" to identify the "> >" occurences in stout.
> used a script to make the replacements and then checked the file diffs by hand.
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message