mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 26734: Ensure docker calls stop if a docker_stop_timeout is provided
Date Wed, 15 Oct 2014 10:01:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26734/#review56681
-----------------------------------------------------------


Bad patch!

Reviews applied: [26734]

Failed command: ./support/mesos-style.py

Error:
 Checking 519 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
src/slave/flags.hpp:333:  Redundant blank line at the end of a code block should be deleted.
 [whitespace/blank_line] [3]
src/slave/containerizer/docker.cpp:1570:  Lines should be <= 80 characters long  [whitespace/line_length]
[2]
src/docker/docker.cpp:469:  Line ends in whitespace.  Consider deleting these extra spaces.
 [whitespace/end_of_line] [4]
src/docker/docker.cpp:471:  Lines should be <= 80 characters long  [whitespace/line_length]
[2]
Total errors found: 4

- Mesos ReviewBot


On Oct. 15, 2014, 9:01 a.m., Ryan Thomas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26734/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 9:01 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1925
>     https://issues.apache.org/jira/browse/MESOS-1925
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added the flag docker_stop_timeout that defaults to 0, if the timeout is 0 the a docker
kill will be run, otherwise a docker stop with the timeout in seconds is used. A negative
value will result in a Failure.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9656f15547a522f9866c28c78d431508771c795a 
>   src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2 
>   src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
>   src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d 
>   src/tests/docker_containerizer_tests.cpp 67d60a885d65edbcbbf702bce83a54d1a5c0411f 
>   src/tests/docker_tests.cpp 04139af2c377226554d53e9dbce93868da1dc1ba 
> 
> Diff: https://reviews.apache.org/r/26734/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo bin/mesos-tests.sh --gtest_filter="*DOCKER*" --verbose
> 
> 
> Thanks,
> 
> Ryan Thomas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message