mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information
Date Wed, 15 Oct 2014 05:21:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26426/#review56661
-----------------------------------------------------------


Patch looks great!

Reviews applied: [26426]

All tests passed.

- Mesos ReviewBot


On Oct. 14, 2014, 11:07 p.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26426/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 11:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Reworks building mesos in "debug" vs. "release". By default, mesos is now built in release
(no debug info, optimized build). If '--enable-debug' is specified to configure, than optimization
will be turned off, and debug info will be turned on.
> 
> This also adds a variable 'DEBUG' to the build environment, which people can use in code
to see if mesos is built with debugging to enable extra assertions / checks. For release builds
we may want to set 'NDEBUG' which removes assert()'s, but that is a seperate discussion.
> 
> Main benefits:
> 1) Getting a build to include/exclude debug information at will is feasible. Before some
things like using clang would forcibly enable debug info in all cases
> 2) libmesos.so and the other binaries which get packaged up for use in distributions
shrink considerably without manually stripping post-build (Improves build time, makes packaging
cleaner)
> 
> 
> Diffs
> -----
> 
>   configure.ac 2b372e06006250b5230956ef096473e98f3fa590 
> 
> Diff: https://reviews.apache.org/r/26426/diff/
> 
> 
> Testing
> -------
> 
> Built with both --enable-debug and without, checking that the flags get passed through
correctly.
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message