mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Thomas" <r...@ryant.org>
Subject Re: Review Request 26709: Change from kill to stop for docker
Date Tue, 14 Oct 2014 23:50:56 GMT


> On Oct. 14, 2014, 11:39 p.m., Ankur Chauhan wrote:
> > src/docker/docker.cpp, line 472
> > <https://reviews.apache.org/r/26709/diff/1/?file=721122#file721122line472>
> >
> >     A 30 second timeout seems pretty arbitrary. I would suggest allowing the user
to specify this as a arg. Something on the lines of: 
> >     
> >     1. If a slave system environment value (eg: `DOCKER_STOP_TIMEOUT`)is set we
use that.
> >     2. If user provides a `-t` option, instead of using the environment variable.
> >     3. If nothing is set, kill as usual.
> >     
> >     The only reason why i suggest these is beacuse a lot of people may already have
the expectation that killing a task will kill the container. This way, the upgrade process
is a smooth upgrade flow.
> 
> Ryan Thomas wrote:
>     Do you think we should kill as usual, or just set a smaller default timeout - i.e.
1 second as the default and allow configuring via env or argument? I know it slightly changes
the behaviour of previous versions, but it would simplify the code path a little by having
the one container stop/kill command.
> 
> Ankur Chauhan wrote:
>     I think that's pretty agreeable but I don't know how docker deals with timeout set
to something obscene like: 
>     
>     1. Negative timeout
>     2. Really large timeout
>     3. 0 timeout
>     
>     These may be trivial questions but I would want to be defensive about these cases.
Probably expanding the test suite is in order.

I'll add to the test suite too with these changes.

I think we should also enforce some bounds for the values, i.e. >0 and <= (executor
timeout) / 2 or something like that.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26709/#review56602
-----------------------------------------------------------


On Oct. 14, 2014, 9:56 p.m., Ryan Thomas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26709/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 9:56 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1925
>     https://issues.apache.org/jira/browse/MESOS-1925
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Change docker kill to docker stop to allow graceful shutdown of containers.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2 
> 
> Diff: https://reviews.apache.org/r/26709/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan Thomas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message