mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process
Date Tue, 14 Oct 2014 21:53:33 GMT


> On Oct. 10, 2014, 5:15 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/process.cpp, line 1631
> > <https://reviews.apache.org/r/26583/diff/1/?file=717970#file717970line1631>
> >
> >     this can't land until https://reviews.apache.org/r/26289/ which contains the
configure.ac check for std::unique_ptr support.

Dominic, what is the expected time frame for landing r26289? It contains more than just the
check and we have a couple of patches that would depend on it. Can we pull out the check in
a new patch to get going?


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26583/#review56262
-----------------------------------------------------------


On Oct. 10, 2014, 4:12 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26583/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 4:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Wrap the libprocess garbage collector process with a unique ptr. Reset the ptr during
finalization.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 85fb995 
> 
> Diff: https://reviews.apache.org/r/26583/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message