mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 26509: Added --module flag for Mesos slave.
Date Fri, 10 Oct 2014 23:26:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26509/#review56251
-----------------------------------------------------------

Ship it!


Barring that tiny style nit.


src/slave/main.cpp
<https://reviews.apache.org/r/26509/#comment96560>

    Alphabetize please.



src/slave/main.cpp
<https://reviews.apache.org/r/26509/#comment96561>

    Not yours but this would trigger a glog warning as it has not yet been initialized. We
should possibly check all runnables for such nits at some  point.


- Till Toenshoff


On Oct. 10, 2014, 10:04 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26509/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 10:04 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added --module flag for Mesos slave.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d 
>   src/slave/main.cpp 2c4d365a04acbcb382e978d811a318130484b3d5 
> 
> Diff: https://reviews.apache.org/r/26509/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message