mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 26470: Removed unused resources and duplicated attributes from Slave.
Date Fri, 10 Oct 2014 20:46:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26470/#review56212
-----------------------------------------------------------

Ship it!



src/tests/slave_tests.cpp
<https://reviews.apache.org/r/26470/#comment96535>

    s/get("")/get()/ ?


- Ben Mahler


On Oct. 10, 2014, 7:41 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26470/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 7:41 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. Right now, the 'resources' obtained from localhost:5051/state.json is not
correct.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp ec7c6b992f72246db0044734785c4d851a27734a 
>   src/slave/slave.hpp 76d505c698774204b2536b66ea8a83a9a2a5e2c1 
>   src/slave/slave.cpp cb3759993f863590cb1545c73072feb0331aa6c9 
>   src/tests/slave_tests.cpp 69be28f6e82b99e23424bd2be8294f715d8040d4 
> 
> Diff: https://reviews.apache.org/r/26470/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message