mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 26533: Memory cleanup: libprocess finalize
Date Fri, 10 Oct 2014 18:37:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26533/#review56192
-----------------------------------------------------------



3rdparty/libprocess/include/process/process.hpp
<https://reviews.apache.org/r/26533/#comment96518>

    Since no one caught this: s/c/C/


- Ben Mahler


On Oct. 10, 2014, 1:02 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26533/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Introduce a finalize() function to match the initialize() function in process.hpp. Use
this at the unit test runner for libprocess to start getting more valuable valgrind feedback.
> - Added cleanup of remaining Processes in ~ProcessManager() as a start.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/process.hpp 270ca28 
>   3rdparty/libprocess/src/process.cpp d30ed63 
>   3rdparty/libprocess/src/tests/main.cpp 0a3ba4e 
> 
> Diff: https://reviews.apache.org/r/26533/diff/
> 
> 
> Testing
> -------
> 
> make check
> support/mesos-style
> valgrind 3rdparty/libprocess/tests (to see a reduction in definitely lost blocks)
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message