mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 26382: [WIP] Annotate TASK_LOST with source. Consider TASK_INVALID for some cases.
Date Thu, 09 Oct 2014 14:07:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 7:07 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

remove MESOS-1


Bugs: MESOS-1830 and MESOS-343
    https://issues.apache.org/jira/browse/MESOS-1830
    https://issues.apache.org/jira/browse/MESOS-343


Repository: mesos-git


Description
-------

Annotating every TASK_LOST with comments to open discussion.

If we add a 'source' field and consider adding TASK_INVALID i think it adds much more information.
I don't think the metrics would have to change as the source matches the source file, I think.
Unless I missed a subtlety. Ie, some of the master TASK_LOST could be set to slave source,
but i think it's debatable.


Diffs
-----

  src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f 
  src/sched/sched.cpp a37ed3d2e11035650b9bf0440fb87f66669129d8 
  src/scheduler/scheduler.cpp fb88a3e029e97ba33eae5d50503be5ed9c9533e6 
  src/slave/slave.cpp e56dcbd80114730949a0d4b553470802a4d38281 

Diff: https://reviews.apache.org/r/26382/diff/


Testing
-------


Thanks,

Dominic Hamon


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message