mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()
Date Thu, 09 Oct 2014 09:10:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26472/#review55961
-----------------------------------------------------------

Ship it!


Please fix the shadowed variable and maybe the minor alignment nits.


3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp
<https://reviews.apache.org/r/26472/#comment96318>

    Align with std::string



3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp
<https://reviews.apache.org/r/26472/#comment96315>

    Shadowed 'message' variable? How about a different name for the local string?



3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp
<https://reviews.apache.org/r/26472/#comment96317>

    Would prefer to see the second line aligned with std::string, after the 'ABORT('
    Same for other changes in this file


- Adam B


On Oct. 8, 2014, 6:20 p.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26472/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 6:20 p.m.)
> 
> 
> Review request for mesos, Adam B and Dominic Hamon.
> 
> 
> Bugs: MESOS-1870
>     https://issues.apache.org/jira/browse/MESOS-1870
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This makes it so any time there is an abort, we get a line number and at least a basic
message as to why there was an abort. If you want a clean(er) exit, use <stout/exit>.
> 
> Also adds an overload which takes a standard string and unwraps it to a const char *
automatically, since a lot of the time we are building strings to pass them to abort.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 6b5b5d1 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9d244b2 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7138bc2 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 8aa21ed 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp ccf80a7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp ce8dd9b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp ed0a1ef 
>   3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp b1af74f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 87c5fc8 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 9207c55 
> 
> Diff: https://reviews.apache.org/r/26472/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message