mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 26206: Introduced Master <-> Slave reconciliation.
Date Wed, 08 Oct 2014 23:39:53 GMT


> On Oct. 1, 2014, 10:30 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 912
> > <https://reviews.apache.org/r/26206/diff/1/?file=709920#file709920line912>
> >
> >     s/no/no need for/
> >     
> >     Can you also add a comment about why this doesn't need to go through the status
update manager?

Turns out this actually does need to go through the status update manager for now because
of MESOS-1879. I also updated the comment to reflect why it has to for now, and why we can
send it directly after MESOS-1879 is resolved.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26206/#review55152
-----------------------------------------------------------


On Oct. 8, 2014, 11:39 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26206/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 11:39 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1696
>     https://issues.apache.org/jira/browse/MESOS-1696
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The master must rely on the slave to reconcile tasks that were missing in the re-registration
message. Otherwise, the master may incorrectly send TASK_LOST in the event of a race.
> 
> See MESOS-1696 for further details.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 37ce31abb45b6d1c4a9c88b0f1e81d1265d382b9 
>   src/master/master.cpp 0286353babdb1ef44ed954e19f02998bc272a6c7 
>   src/messages/messages.proto b8039efa1638995c2846f5cb515919d5e51cde5c 
>   src/slave/slave.hpp 28697102047b972ecb3b6b627ee089b430549fc0 
>   src/slave/slave.cpp 809b008b1502b80cce4d8b4be0a233117c92ed56 
>   src/tests/fault_tolerance_tests.cpp e8f532232c091849489971d7fc96ae615ffb6de0 
> 
> Diff: https://reviews.apache.org/r/26206/diff/
> 
> 
> Testing
> -------
> 
> make check, and modified the test that captured the TASK_LOST case. Added another test
in a subsequent review.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message