mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 26352: Add --with-curl to libprocess since <stout/net.hpp> needs it.
Date Tue, 07 Oct 2014 08:15:45 GMT


> On Oct. 6, 2014, 1:30 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/configure.ac, line 99
> > <https://reviews.apache.org/r/26352/diff/1/?file=714029#file714029line99>
> >
> >     Is there a reason you are not adhering to that without_bundled_xxx scheme we
are using for other bundled libraries?
> 
> Timothy St. Clair wrote:
>     same sentiments.
> 
> Michael Park wrote:
>     The initial reason was simply because I took this snippet from the mesos `configure.ac`.
But `curl` is not a bundled library at least at this point. Do you guys think we should bundle
it?
> 
> Benjamin Hindman wrote:
>     IMHO we don't need to bundle curl. This looks like a good addition MPark, I guess
this was overlooked the first time we added these checks to Mesos.
> 
> Michael Park wrote:
>     Thanks Ben, yeah my guess is that it was tested on a machine with system-level `libcurl`
and so it was able to find the header in `/usr/include`.

Makes sense MPark, thanks for clearifying.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26352/#review55495
-----------------------------------------------------------


On Oct. 6, 2014, 1:50 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26352/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 1:50 p.m.)
> 
> 
> Review request for mesos and Timothy St. Clair.
> 
> 
> Bugs: MESOS-1843
>     https://issues.apache.org/jira/browse/MESOS-1843
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> libprocess uses `<stout/net.hpp>` which includes `<curl/curl.h>`. On a machine
without system-level libcurl installed, we should be able to build `mesos` with the `--with-curl=<path-to-libcurl>`
flag. The `-I<path-to-libcurl>` gets added to the `CPPFLAGS` for `mesos` but it doesn't
added for libprocess. This patch makes libprocess actually use the `--with-curl` flag.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 501de4076b6c3b996580d6656bc50103dcedc154 
> 
> Diff: https://reviews.apache.org/r/26352/diff/
> 
> 
> Testing
> -------
> 
> Built `mesos` on a machine without system-level libcurl installed with `--with-curl`
flag.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message