mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 26389: Fixed ~Authenticator() to discard the promise.
Date Mon, 06 Oct 2014 22:30:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26389/#review55589
-----------------------------------------------------------


can this be removed when https://reviews.apache.org/r/25945/ lands?


src/sasl/authenticatee.hpp
<https://reviews.apache.org/r/26389/#comment95946>

    this should probably be a failure rather than a discard. A discard is meant to be user-initiated.


- Dominic Hamon


On Oct. 6, 2014, 3:28 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26389/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 3:28 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Jie Yu.
> 
> 
> Bugs: MESOS-1866
>     https://issues.apache.org/jira/browse/MESOS-1866
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This fixes the race condition #2 as discussed in MESOS-1866.
> 
> 
> Diffs
> -----
> 
>   src/sasl/authenticatee.hpp dd68704c4851d28114dd632cd8e16882b2e30ebe 
>   src/sasl/authenticator.hpp 35ab79449093e10877248b91ba7070e04c9cdd6f 
>   src/tests/sasl_tests.cpp 59e1c95370879d4b006bfd80f16ce2a1f54a61df 
> 
> Diff: https://reviews.apache.org/r/26389/diff/
> 
> 
> Testing
> -------
> 
> Ensured that the test failed without the fix.
> 
> Ran the test 10K times in repitition with the fix.
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message