mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 26352: Add --with-curl to libprocess since <stout/net.hpp> needs it.
Date Sun, 05 Oct 2014 09:55:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26352/#review55473
-----------------------------------------------------------


Patch looks great!

Reviews applied: [26352]

All tests passed.

- Mesos ReviewBot


On Oct. 5, 2014, 9:02 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26352/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2014, 9:02 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1843
>     https://issues.apache.org/jira/browse/MESOS-1843
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> libprocess uses `<stout/net.hpp>` which includes `<curl/curl.h>`. On a machine
without system-level libcurl installed, we should be able to build `mesos` with the `--with-curl=<path-to-libcurl>`
flag. The `-I<path-to-libcurl>` gets added to the `CPPFLAGS` for `mesos` but it doesn't
added for libprocess. This patch makes libprocess actually use the `--with-curl` flag.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 501de4076b6c3b996580d6656bc50103dcedc154 
> 
> Diff: https://reviews.apache.org/r/26352/diff/
> 
> 
> Testing
> -------
> 
> Built `mesos` on a machine without system-level libcurl installed with `--with-curl`
flag.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message