mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 26253: Check for IP address being localhost not platform independent
Date Thu, 02 Oct 2014 00:14:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26253/#review55163
-----------------------------------------------------------


Patch looks great!

Reviews applied: [26253]

All tests passed.

- Mesos ReviewBot


On Oct. 1, 2014, 11:34 p.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26253/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 11:34 p.m.)
> 
> 
> Review request for mesos and Jay Buffington.
> 
> 
> Bugs: MESOS-1835
>     https://issues.apache.org/jira/browse/MESOS-1835
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced ip value comparison with 2130706433  or 0 with inet_ntop and string comparison
to avoid endianess problems
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp d30ed636ee24d0fe6e62f69a921307bde1f32765 
> 
> Diff: https://reviews.apache.org/r/26253/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message